All committers have signed the CLA.

There are 2 things that are unclear to me:
1- can you explain the reasoning for the double pointer on http.Request?
2- I don't understand how could you have used the ` for the imports

There are 2 things that are unclear to me:
1- can you explain the reasoning for the double pointer on http.Request?
2- I don't understand how could you have used the ` for the imports

As for the import， it shocks me too🤣. It was mostly generated by the goland IDE. I am sorry I didn't check formattings before checking in.

As for the double pointer, the http.Request.WithContext works in a immutable way, it should returns a new instance when change the context. It looks cohensive to make the change inside the NewResponseRecorder implementation.

    c := context.WithValue(r.Context(), ResponseRecorderVarKey, rr)
    *req = r.WithContext(c)

A alternative way is to let the invoker to take care of the new r . The side effect is not obvious for the invoker(The input r changed??)

    func NewResponseRecorder(w http.ResponseWriter, req *http.Request, buf *bytes.Buffer,
	shouldBuffer ShouldBufferFunc) (wrec ResponseRecorder, newReq *http.Request , cached bool)
    // ....
    wrec, r, cached := NewResponseRecorder(w, r, nil, nil)

It's weird to input a double pointer but it's may get the invoker's attention as I had thought.

What's your opinion on the alternatives ?

I converted this PR to draft. During review the caching of responseRecorder, I found its better to decouple responseRecorder into responseBuffer and responseMeter. I will do some more investigation.

I converted this PR to draft. During review the caching of responseRecorder, I found its better to decouple responseRecorder into responseBuffer and responseMeter. I will do some more investigation.

I have to admit it's complicate than I had expencted 🤣. It's better to make this PR scope smaller and focus on the issue of adding http.request.size only. I will submit a single refactor-purpose PR for the responsewriter splitting.

I will submit it for a later time.